Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a Realm as read-only #260

Merged
merged 24 commits into from
Feb 18, 2022
Merged

Opening a Realm as read-only #260

merged 24 commits into from
Feb 18, 2022

Conversation

desistefanova
Copy link
Contributor

Added support for read-only realm. Fixes #92

@cla-bot cla-bot bot added the cla: yes label Feb 17, 2022
@coveralls
Copy link

coveralls commented Feb 17, 2022

Pull Request Test Coverage Report for Build 1864526210

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.35%

Totals Coverage Status
Change from base Build 1863688971: 0.0%
Covered Lines: 379
Relevant Lines: 406

💛 - Coveralls

@desistefanova desistefanova requested review from blagoev and nielsenko and removed request for blagoev February 17, 2022 13:58
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions

lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
lib/src/configuration.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
test/realm_test.dart Outdated Show resolved Hide resolved
desistefanova and others added 18 commits February 18, 2022 11:50
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <lubo@blagoev.com>
Co-authored-by: blagoev <blagoev@users.noreply.github.com>
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its ok, only Changelog file has some not needed changes.

CHANGELOG.md Outdated
@@ -3,10 +3,14 @@ x.x.x Release notes (yyyy-MM-dd)

**This project is in the Alpha stage. All API's might change without warning and no guarantees are given about stability. Do not use it in production.**

### Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a wrong merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@desistefanova desistefanova merged commit 2f77fdf into master Feb 18, 2022
@desistefanova desistefanova deleted the config_isReadOnly branch February 18, 2022 13:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config: Support opening a Realm as readonly
3 participants